-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kaggle user agent to gcp integration clients. #671
Conversation
This works for all integrations except the automl TablesClient, they have a bug in their client initialization where if you provide a client_info= parameter it throws Cause of it is this line, where they get a client_info from kwargs, but then pass it as a parameter again, so it's passed in twice (as a named parameter and in the original kwargs): This should be easy to fix, I'll sent them an PR/Issue for it. |
Note, the |
I have fixed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
# TODO(vimota): Remove the exclusion of TablesClient once | ||
# the client has fixed the error: | ||
# `multiple values for keyword argument 'client_info'`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that an actual error that you see if this is set? I was hoping that Python would just ignore the kwargs value if a named value was already passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah unfortunately it's a type error :( https://stackoverflow.com/questions/21764770/typeerror-got-multiple-values-for-argument
Thanks, rebased and rerunning! |
No description provided.